Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For #307: Error chomp on nil #308

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

For #307: Error chomp on nil #308

wants to merge 2 commits into from

Conversation

Taknok
Copy link

@Taknok Taknok commented Mar 15, 2022

Set a control to check if gets return a non nil object and chomp it.

=> Referenced issue #307

Taknok added 2 commits March 15, 2022 22:21
@Taknok
Fix error chomp on nil
15efa9f 
gets may return nil and chomp cannot be done on nil
@Taknok
set bin executable to suppress warning
4104e7e
@Taknok Taknok mentioned this pull request Mar 15, 2022
Open
skull-squadron added a commit to skull-squadron/svn2git that referenced this pull request Jan 14, 2024
@skull-squadron
Close nirvdrum#284, nirvdrum#307; supersede nirvdrum#285, nirvdrum#278,
6267250 
nirvdrum#308

The proper way to do subprocess I/O is to do less.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swaroopbekal swaroopbekal swaroopbekal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Taknok @swaroopbekal