-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repair 3dQwarp workflow #454
Draft
psadil
wants to merge
15
commits into
nipreps:master
Choose a base branch
from
psadil:fix/issue-442
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 9 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
19677a1
Repair 3dQwarp workflow
psadil dc296de
Lint
psadil d7f58a5
More linting
psadil f8f601c
Add missing fsl dependency for testing
psadil afc1a7d
Add fsl-beet2 to env.yml for docker
psadil 48ad74c
Keep 3dQwarp in docker image
psadil 1a11859
Allow getting trt when TotalReadoutTime not in metadata
psadil 7b72302
Add informative error when TotalReadoutTime not in metadata and in_fi…
psadil dd5f251
Improve test coverage
psadil 9b40a9d
Improve exception
psadil 923ab4a
manually undo accidental linting
psadil d66c86e
Update sdcflows/utils/tests/test_epimanip.py
psadil 0275bb2
manually undo accidental linting
psadil 166be74
manually undo accidental linting
psadil ac5f87a
more accidental linting
psadil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
# emacs: -*- mode: python; py-indent-offset: 4; indent-tabs-mode: nil -*- | ||
# vi: set ft=python sts=4 ts=4 sw=4 et: | ||
# | ||
# Copyright 2021 The NiPreps Developers <[email protected]> | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
# We support and encourage derived works from this project, please read | ||
# about our expectations at | ||
# | ||
# https://www.nipreps.org/community/licensing/ | ||
# | ||
"""Test EPI manipulation routines.""" | ||
import pytest | ||
from sdcflows.utils.epimanip import get_trt | ||
|
||
|
||
def test_get_trt_err_wo_trt_and_in_file(): | ||
"""Test that calling get_trt with dict that does not have TotalReadoutTime \ | ||
and no in_file raises AssertionError. | ||
""" | ||
with pytest.raises(AssertionError): | ||
psadil marked this conversation as resolved.
Show resolved
Hide resolved
|
||
get_trt(in_meta={}) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you using BET anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pipeline still uses init_enhance_and_skullstrip_bold_wf, which depends on BET: https://github.com/nipreps/niworkflows/blob/1f9a0cf6d5b74e1aadf544841a0adaee19cc63b0/niworkflows/func/util.py#L391-L393