-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove non-alphanumeric characters from workflow names and output entities #434
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #434 +/- ##
==========================================
- Coverage 76.43% 76.41% -0.03%
==========================================
Files 32 32
Lines 2835 2841 +6
Branches 376 376
==========================================
+ Hits 2167 2171 +4
- Misses 600 602 +2
Partials 68 68 ☔ View full report in Codecov by Sentry. |
This is causing an error upstream:
We probably want to either change |
Let's revert. We can rethink this. |
Reverted. What if we replace all non-alphanumeric characters with underscores? |
Removing or replacing both sound reasonable - it's just the sanitized id needs to be available within the |
Closes #295.
Changes proposed: