Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable use native BarcodeDetector on MacOS Ventura with M chips #243

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable use native BarcodeDetector on MacOS Ventura with M chips #243

wants to merge 1 commit into from

Conversation

alsherko
Copy link

Issue https://bugs.chromium.org/p/chromium/issues/detail?id=1382442 Verified in Chrome 113.0.5620.0.

Returned the use of native BarcodeDetector on MacOS Ventura with M chips

@alsherko alsherko changed the title Enable native BarcodeDetector on M chips with Ventura Enable use native BarcodeDetector on MacOS Ventura with M chips Aug 20, 2023
sisou
sisou requested changes Aug 22, 2023
View reviewed changes
Copy link
Member

@sisou sisou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing the check for M* Macs completely, it should still detect and use the workaround in Chromium versions <113.

@alsherko alsherko requested a review from sisou August 22, 2023 09:44
sisou
sisou approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@sisou sisou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, handing over to @danimoh

src/qr-scanner.ts Outdated Show resolved Hide resolved
@laszlo1337
Copy link

Any chance this gets merged?

laszlo1337 added a commit to laszlo1337/qr-scanner that referenced this pull request Dec 12, 2023
@laszlo1337
Implement BarcodeDetector formats override -> nimiq#207
702b474 
Apply nimiq#243
laszlo1337 added a commit to laszlo1337/qr-scanner that referenced this pull request Dec 12, 2023
@laszlo1337
Implement BarcodeDetector formats override -> nimiq#207
0e49518 
Apply nimiq#243
laszlo1337 added a commit to laszlo1337/qr-scanner that referenced this pull request Dec 12, 2023
@laszlo1337
Implement BarcodeDetector formats override -> nimiq#207
552b11c 
Apply nimiq#243
laszlo1337 added a commit to laszlo1337/qr-scanner that referenced this pull request Dec 12, 2023
@laszlo1337
Implement BarcodeDetector formats override -> nimiq#207
13783e5 
Apply nimiq#243
laszlo1337 added a commit to laszlo1337/qr-scanner that referenced this pull request Dec 12, 2023
@laszlo1337
Implement BarcodeDetector formats override -> nimiq#207
fd07f81 
Apply nimiq#243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sisou sisou sisou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alsherko @laszlo1337 @sisou