Fix and improvements for postgres and asdf

[liamstevens111]

Close #37

What happened

• Fixed postgres installation by changing the brew package from postgres to postgresql@<version>
• asdf:
  • asdf.sh is situated inside an additional directory /libexec during install so the paths have been updated
  • Fixed existing shims export in .zshrc as it had a trailing " so the commands wouldn't be available (I actually added an opening " with $HOME instead of keeping existing ~ and deleting the trailing comma. I think this change is same.
  • Included the above shims export to .zshrc if the oh-my-zsh add-on was chosen at the end (because it overwrites it). If this isn't added then the same errors "command not found" would re-occur again.
• Added a check for existing postgres on the system prior to installing the postgresql brew package and the function responsible for starting/stopping postgres service and creating the new database user.

Insight

1. The explicit version of postgresql seems to be required for brew. The following error is shown if just changed to postgresql without version:

Warning: No available formula with the name "postgresql". Did you mean postgresql@13, postgresql@12, postgresql@11, postgresql@15, postgresql@10, postgresql@14, [email protected], [email protected], postgrest or qt-postgresql?
postgresql breaks existing databases on upgrade without human intervention.

So have chosen 14 which would be 14.7 which is only a few months old (didn't want to try 15 but willing to change).

2. For the postgres existing installation pre-check I have included the location of /Applications/Postgres.app (https://postgresapp.com) in addition to brew in case a user has an existing installation by this method instead (willing to change)

Potential improvements

• Make a global variable for postgresql version number
• Change existing shell command which to a folder check depending on if M1 or otherwise for existing postgres check.

Proof Of Work

Success output when running script - https://pastebin.com/N8kVaTBE

[Nihisil]

Can we move it to a separate method? So, in case it is changed in the future, we don't need to modify it again in all places.

[liamstevens111]

A method or a variable? Unsure to be honest, maybe we can do this in a refactor task if needed

[Nihisil]

Sure

[Nihisil]

It is worth to do option from "Potential improvements" in this PR:

Make a global variable for postgresql version number

[liamstevens111]

I thought about it but wasn't 100% sure the version number would directly map to the folder paths in the future, and unsure if we will remove/refactor the setup_postgres where it's used 3 out of the 4 times.

[Nihisil]

Ok

[Nihisil]

If we added it here, should we remove it from install_asdf()?

[liamstevens111]

I don't think so because if the user decides to not install oh-my-zsh at the last step they won't have it at all.