make all sizeof calls in codegen use types #24433
Draft
+9
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 15, 2024
Araq
pushed a commit
that referenced
this pull request
Nov 17, 2024
metagn
force-pushed
the
cbuilder-sizeof
branch
from
8a3bf29 to
df33749
Compare
metagn
force-pushed
the
cbuilder-sizeof
branch
from
df33749 to
5f55c4d
Compare
|
Make it opt-in for the NIFC generation. For the old codegen the possible regressions are of the worst kind and not worth the risks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follows up #24445, refs nim-lang/nimony#120
Not sure if using
sizeof(loc.t)is always correct