Skip to content

Commit

Permalink
LibPDF: Read /Flags off font descriptors
Browse files Browse the repository at this point in the history
  • Loading branch information
nico committed Feb 24, 2024
1 parent 05d5e11 commit 28805a4
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 1 deletion.
1 change: 1 addition & 0 deletions Userland/Libraries/LibPDF/CommonNames.h
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@
X(FitH) \
X(FitR) \
X(FitV) \
X(Flags) \
X(FlateDecode) \
X(Font) \
X(FontDescriptor) \
Expand Down
8 changes: 7 additions & 1 deletion Userland/Libraries/LibPDF/Fonts/PDFFont.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,14 @@ PDFErrorOr<NonnullRefPtr<PDFFont>> PDFFont::create(Document* document, NonnullRe
return font.release_nonnull();
}

PDFErrorOr<void> PDFFont::initialize(Document*, NonnullRefPtr<DictObject> const&, float)
PDFErrorOr<void> PDFFont::initialize(Document* document, NonnullRefPtr<DictObject> const& dict, float)
{
if (dict->contains(CommonNames::FontDescriptor)) {
auto descriptor = TRY(dict->get_dict(document, CommonNames::FontDescriptor));
if (descriptor->contains(CommonNames::Flags))
m_flags = descriptor->get_value(CommonNames::Flags).to_int();
}

return {};
}

Expand Down
15 changes: 15 additions & 0 deletions Userland/Libraries/LibPDF/Fonts/PDFFont.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,24 @@ class PDFFont : public RefCounted<PDFFont> {
virtual void set_font_size(float font_size) = 0;
virtual PDFErrorOr<Gfx::FloatPoint> draw_string(Gfx::Painter&, Gfx::FloatPoint, ByteString const&, Renderer const&) = 0;

// TABLE 5.20 Font flags
bool is_fixed_pitch() const { return m_flags & (1 << (1 - 1)); }
bool is_serif() const { return m_flags & (1 << (2 - 1)); }
bool is_symbolic() const { return m_flags & (1 << (3 - 1)); }
bool is_script() const { return m_flags & (1 << (4 - 1)); }
// Note: No bit position 5.
bool is_nonsymbolic() const { return m_flags & (1 << (6 - 1)); }
bool is_italic() const { return m_flags & (1 << (7 - 1)); }
// Note: Big jump in bit positions.
bool is_all_cap() const { return m_flags & (1 << (17 - 1)); }
bool is_small_cap() const { return m_flags & (1 << (18 - 1)); }
bool is_force_bold() const { return m_flags & (1 << (19 - 1)); }

protected:
virtual PDFErrorOr<void> initialize(Document* document, NonnullRefPtr<DictObject> const& dict, float font_size);
static PDFErrorOr<NonnullRefPtr<Gfx::Font>> replacement_for(StringView name, float font_size);

unsigned m_flags { 0 };
};

}

0 comments on commit 28805a4

Please sign in to comment.