AK: Pass (Deprecated)FlyString::is_one_of arguments by reference

This avoid unnecessairy reference counting. (cherry picked from commit 22a66bb1c2afde93096d9866d6386e2bca955f71)
nico · Nov 15, 2024 · 18b020a · 18b020a
1 parent fcfe89e
commit 18b020a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/AK/DeprecatedFlyString.h b/AK/DeprecatedFlyString.h
@@ -84,7 +84,7 @@ class DeprecatedFlyString {
     static void did_destroy_impl(Badge<StringImpl>, StringImpl&);
 
     template<typename... Ts>
-    [[nodiscard]] ALWAYS_INLINE constexpr bool is_one_of(Ts... strings) const
+    [[nodiscard]] ALWAYS_INLINE constexpr bool is_one_of(Ts&&... strings) const
     {
         return (... || this->operator==(forward<Ts>(strings)));
     }

diff --git a/AK/FlyString.h b/AK/FlyString.h
@@ -71,7 +71,7 @@ class FlyString {
     [[nodiscard]] bool ends_with_bytes(StringView, CaseSensitivity = CaseSensitivity::CaseSensitive) const;
 
     template<typename... Ts>
-    [[nodiscard]] ALWAYS_INLINE constexpr bool is_one_of(Ts... strings) const
+    [[nodiscard]] ALWAYS_INLINE constexpr bool is_one_of(Ts&&... strings) const
     {
         return (... || this->operator==(forward<Ts>(strings)));
     }