Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tests compatible with icalendar v5 #169

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

dotlambda
Copy link
Contributor

icalendar v5 doesn't have use_pytz and use_zoneinfo

if hasattr(icalendar, 'use_pytz') and hasattr(icalendar, 'use_zoneinfo'):
tzps = [icalendar.use_pytz, icalendar.use_zoneinfo]
else:
tzps = [lambda: ...]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks nice!

Thanks!

@niccokunzmann niccokunzmann merged commit 0d5ab4e into niccokunzmann:main Aug 26, 2024
7 checks passed
@niccokunzmann
Copy link
Owner

Thanks!
If you like, you can add it to the Changelog Section in the README.

@dotlambda dotlambda deleted the icalendar-v5 branch August 26, 2024 21:14
@niccokunzmann
Copy link
Owner

@dotlambda would you like to open an issue or PR so that icalendarv5 gets tested by the CI? Otherwise, I might work on it and break the tests again. Also, icalendar will release version 6 in October with Python 3.8 facing End of Life, so maybe this is not such an issue, only for 1 month. But I see that from the outside perspective, testing with the current release of icalendar looks valuable... What are your thoughts on this?

@dotlambda
Copy link
Contributor Author

icalendar will release version 6 in October

Then I don't care very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants