-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export to xls for compatibility mode #1983
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생많으셨습니다. 리뷰 완료합니다.
P4 : 직접적으로 xls
포맷을 넘겨 테스트하는 건 확인했습니다. 가이드에선 excelCompatibilityMode: true
로 설정하라고 추가해두셨던데 해당 설정으로 테스트하는 건 없어보이네요. 추가하는건 어떠세요?
호환 모드에서 포맷을 실제 파일을 쓰기 직전에 바꿔서 이벤트에서는 이를 알아낼 수 없는데요, 관련된 모듈을 모킹해보려 했으나 올바르게 동작하지 않아 테스트를 작성할 수 없었습니다.. ㅠㅠ |
앗 그렇군요 알겠습니다ㅜㅜ |
Please check if the PR fulfills these requirements
fix #xxx[,#xxx]
, where "xxx" is the issue number)Description
Added support for exporting to XLS format for use in older versions of Excel that do not support XLSX format.
And added an option
excelCompatibilityMode
to change the default format for excel export from xlsx to xls for compatibility mode. If you set this option totrue
, it will export files in xls format by default when excel exporting.Thank you for your contribution to TOAST UI product. 🎉 😘 ✨