-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP/DP Split: Add agent/nginx container and deployment #2958
CP/DP Split: Add agent/nginx container and deployment #2958
Conversation
Updating the nginx docker containers to build and include agent. Once agent is officially released, we can use the published binary instead of building. Added a temporary nginx deployment to the helm chart to deploy a standalone nginx pod. Added the basic gRPC server and agent API implementation to allow for the agent pod to connect to the control plane without errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## change/control-data-plane-split #2958 +/- ##
===================================================================
- Coverage 89.74% 89.58% -0.17%
===================================================================
Files 109 108 -1
Lines 11150 11091 -59
Branches 50 50
===================================================================
- Hits 10007 9936 -71
- Misses 1083 1102 +19
+ Partials 60 53 -7 ☔ View full report in Codecov by Sentry. |
2e529b4
into
change/control-data-plane-split
Updating the nginx docker containers to build and include agent. Once agent is officially released, we can use the published binary instead of building.
Added a temporary nginx deployment to the helm chart to deploy a standalone nginx pod.
Added the basic gRPC server and agent API implementation to allow for the agent pod to connect to the control plane without errors.
Testing: Verified that the nginx/agent pod starts up successfully and connects to the control plane.
Closes #2839
Closes #2840