Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP/DP Split: Add agent/nginx container and deployment #2958

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

sjberman
Copy link
Contributor

Updating the nginx docker containers to build and include agent. Once agent is officially released, we can use the published binary instead of building.

Added a temporary nginx deployment to the helm chart to deploy a standalone nginx pod.

Added the basic gRPC server and agent API implementation to allow for the agent pod to connect to the control plane without errors.

Testing: Verified that the nginx/agent pod starts up successfully and connects to the control plane.

Closes #2839
Closes #2840

Updating the nginx docker containers to build and include agent. Once agent is officially released, we can use the published binary instead of building.

Added a temporary nginx deployment to the helm chart to deploy a standalone nginx pod.

Added the basic gRPC server and agent API implementation to allow for the agent pod to connect to the control plane without errors.
@sjberman sjberman requested a review from a team as a code owner December 30, 2024 16:42
@github-actions github-actions bot added dependencies Pull requests that update a dependency file chore Pull requests for routine tasks helm-chart Relates to helm chart labels Dec 30, 2024
Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

build/Dockerfile.nginx Show resolved Hide resolved
internal/mode/static/nginx/agent/command.go Show resolved Hide resolved
internal/mode/static/nginx/agent/file.go Outdated Show resolved Hide resolved
internal/mode/static/nginx/agent/grpc.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 116 lines in your changes missing coverage. Please review.

Project coverage is 89.58%. Comparing base (6337c97) to head (57cb436).
Report is 7 commits behind head on change/control-data-plane-split.

Files with missing lines Patch % Lines
internal/mode/static/nginx/agent/command.go 0.00% 47 Missing ⚠️
internal/mode/static/nginx/agent/file.go 0.00% 24 Missing ⚠️
internal/mode/static/nginx/agent/grpc.go 0.00% 23 Missing ⚠️
internal/mode/static/manager.go 0.00% 15 Missing ⚠️
internal/mode/static/nginx/agent/agent.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##           change/control-data-plane-split    #2958      +/-   ##
===================================================================
- Coverage                            89.74%   89.58%   -0.17%     
===================================================================
  Files                                  109      108       -1     
  Lines                                11150    11091      -59     
  Branches                                50       50              
===================================================================
- Hits                                 10007     9936      -71     
- Misses                                1083     1102      +19     
+ Partials                                60       53       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjberman sjberman requested a review from kate-osborn January 2, 2025 17:25
@sjberman sjberman merged commit 2e529b4 into change/control-data-plane-split Jan 2, 2025
26 of 27 checks passed
@sjberman sjberman deleted the chore/agent-container branch January 2, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies Pull requests that update a dependency file helm-chart Relates to helm chart
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants