Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update wget container for SRA_FASTQ_FTP from 1.20.1 to 1.21.4 #303

Merged
merged 5 commits into from
Mar 22, 2024
Merged

update wget container for SRA_FASTQ_FTP from 1.20.1 to 1.21.4 #303

merged 5 commits into from
Mar 22, 2024

Conversation

ajandria
Copy link

PR checklist

wget fails with wget: unable to resolve host address 'ftp.sra.ebi.ac.uk' as in #291.
This PR updates the container version for SRA_FASTQ_FTP from 1.20.1 to 1.21.4 which fixes this issue.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/fetchngs branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit d2641e4

+| ✅ 155 tests passed       |+
#| ❔   5 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: assets/multiqc_config.yml
  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml

❔ Tests ignored:

  • files_exist - File is ignored: conf/modules.config
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • actions_ci - actions_ci
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/fetchngs/fetchngs/.github/workflows/awstest.yml
  • multiqc_config - 'assets/multiqc_config.yml' not found

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-03-22 12:16:23

@ajandria ajandria requested a review from maxulysse March 21, 2024 16:26
maxulysse
maxulysse reviewed Mar 22, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
maxulysse
maxulysse requested changes Mar 22, 2024
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add this in the CHANGELOG.
in the Enhancements & fixes section?

@ajandria
Copy link
Author

@maxulysse Done!

@maxulysse maxulysse merged commit 3ace2a6 into nf-core:dev Mar 22, 2024
62 checks passed
@maxulysse maxulysse mentioned this pull request Mar 23, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajandria @maxulysse