-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow output definition #275
Changes from 14 commits
9b3a10d
b03ed3b
b8dd9e2
98b6574
5647bd1
4405674
47fa3f9
ec29439
48c6675
9beb5ea
5b3587b
9e8ef57
35aaddd
77bdd19
3ca8a28
bb7febb
c01bd0c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
$schema: 'http://json-schema.org/draft-07/schema' | ||
$id: 'https://raw.githubusercontent.com/nf-core/fetchngs/master/assets/schema_mappings.yml' | ||
title: 'nf-core/fetchngs pipeline - id_mappings.csv schema' | ||
description: 'Schema for the mappings file produced by fetchngs' | ||
type: array | ||
items: | ||
type: object | ||
properties: | ||
sample: | ||
type: string | ||
experiment_accession: | ||
type: string | ||
run_accession: | ||
type: string | ||
sample_accession: | ||
type: string | ||
experiment_alias: | ||
type: string | ||
run_alias: | ||
type: string | ||
sample_alias: | ||
type: string | ||
experiment_title: | ||
type: string | ||
sample_title: | ||
type: string | ||
sample_description: | ||
type: string |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
$schema: 'http://json-schema.org/draft-07/schema' | ||
$id: 'https://raw.githubusercontent.com/nf-core/fetchngs/master/assets/schema_mappings.yml' | ||
title: 'nf-core/fetchngs pipeline - samplesheet.csv schema' | ||
description: 'Schema for the samplesheet file produced by fetchngs' | ||
type: array | ||
items: | ||
type: object | ||
properties: | ||
sample: | ||
type: string | ||
fastq_1: | ||
type: string | ||
format: file-path | ||
pattern: '^\\S+\\.f(ast)?q\\.gz$' | ||
fastq_2: | ||
type: string | ||
format: file-path | ||
pattern: '^\\S+\\.f(ast)?q\\.gz$' | ||
run_accession: | ||
type: string | ||
experiment_accession: | ||
type: string | ||
sample_accession: | ||
type: string | ||
secondary_sample_accession: | ||
type: string | ||
study_accession: | ||
type: string | ||
secondary_study_accession: | ||
type: string | ||
submission_accession: | ||
type: string | ||
run_alias: | ||
type: string | ||
experiment_alias: | ||
type: string | ||
sample_alias: | ||
type: string | ||
study_alias: | ||
type: string | ||
library_layout: | ||
type: string | ||
library_selection: | ||
type: string | ||
library_source: | ||
type: string | ||
library_strategy: | ||
type: string | ||
library_name: | ||
type: string | ||
instrument_model: | ||
type: string | ||
instrument_platform: | ||
type: string | ||
base_count: | ||
type: integer | ||
read_count: | ||
type: integer | ||
tax_id: | ||
type: string | ||
scientific_name: | ||
type: string | ||
sample_title: | ||
type: string | ||
experiment_title: | ||
type: string | ||
study_title: | ||
type: string | ||
sample_description: | ||
type: string | ||
fastq_md5: | ||
type: string | ||
pattern: '^[0-9a-f]{32}$' | ||
fastq_bytes: | ||
type: integer | ||
fastq_ftp: | ||
type: string | ||
fastq_galaxy: | ||
type: string | ||
fastq_aspera: | ||
type: string |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,5 @@ | ||
process { | ||
withName: 'ASPERA_CLI' { | ||
ext.args = '-QT -l 300m -P33001' | ||
publishDir = [ | ||
[ | ||
path: { "${params.outdir}/fastq" }, | ||
mode: params.publish_dir_mode, | ||
pattern: "*.fastq.gz" | ||
], | ||
[ | ||
path: { "${params.outdir}/fastq/md5" }, | ||
mode: params.publish_dir_mode, | ||
pattern: "*.md5" | ||
] | ||
] | ||
} | ||
} |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,5 @@ | ||
process { | ||
withName: 'SRA_FASTQ_FTP' { | ||
ext.args = '-t 5 -nv -c -T 60' | ||
publishDir = [ | ||
[ | ||
path: { "${params.outdir}/fastq" }, | ||
mode: params.publish_dir_mode, | ||
pattern: "*.fastq.gz" | ||
], | ||
[ | ||
path: { "${params.outdir}/fastq/md5" }, | ||
mode: params.publish_dir_mode, | ||
pattern: "*.md5" | ||
] | ||
] | ||
} | ||
} |
This file was deleted.
This file was deleted.
This file was deleted.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
This file was deleted.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I feel like this top-level schema file could be automatically generated from the output DSL (e.g. with a nextflow command) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
$schema: 'http://json-schema.org/draft-07/schema' | ||
$id: 'https://raw.githubusercontent.com/nf-core/fetchngs/master/output.yml' | ||
title: 'nf-core/fetchngs pipeline outputs' | ||
description: '' | ||
type: object | ||
properties: | ||
id_mappings: | ||
type: string | ||
format: file-path | ||
mimetype: text/csv | ||
schema: assets/schema_mappings.yml | ||
samplesheet: | ||
type: string | ||
format: file-path | ||
mimetype: text/csv | ||
schema: assets/schema_samplesheet.yml |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,3 @@ | ||
includeConfig "../../modules/local/multiqc_mappings_config/nextflow.config" | ||
includeConfig "../../modules/local/aspera_cli/nextflow.config" | ||
includeConfig "../../modules/local/sra_fastq_ftp/nextflow.config" | ||
includeConfig "../../modules/local/sra_ids_to_runinfo/nextflow.config" | ||
includeConfig "../../modules/local/sra_runinfo_to_ftp/nextflow.config" | ||
includeConfig "../../modules/local/sra_to_samplesheet/nextflow.config" | ||
includeConfig "../../modules/nf-core/sratools/prefetch/nextflow.config" | ||
includeConfig "../../subworkflows/nf-core/fastq_download_prefetch_fasterqdump_sratools/nextflow.config" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, so the first
fastq
is the path, and the second is the topic.Can it be a bit more explicit?
Thinking something like this at least:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can specify a trailing slash if you want
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like that, it makes the path more explicit, but I'd rather even have a
path
and atopic
specified somewhere, not to be too confused, I think it's better to be a bit more explicitThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair. This case is simple enough to be confusing, but if you used a regular emit instead of a topic, or you had a more complex directory structure like in rnaseq, it would be clearer.
I did propose calling it
fromTopic
to help denote it as a topic, but Paolo was in favor of not having too many different keywords. We could revisit this