Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: filter channel feeds by fids #270

Merged
merged 2 commits into from
Dec 22, 2024
Merged

feat: filter channel feeds by fids #270

merged 2 commits into from
Dec 22, 2024

Conversation

valerierose
Copy link
Contributor

@valerierose valerierose commented Dec 20, 2024 •
edited
Loading

Description of the Change

Add optional fids param to /v2/feeds/channels

OAS Change Summary

Updated Endpoints

  • GET /v2/farcaster/feed/channels - Added optional fids param.

Checklist

  • I have validated that all new/updated endpoints conform to OAS standards.
  • I have updated or added necessary schema definitions.
  • I have ensured that the new schema I have added doesn't exist.
  • I have added description wherever necessary.
  • I have ensured that endpoint's responses are correct.
  • I have considered backward compatibility with previous versions of the API.
  • I have communicated any breaking changes to the appropriate stakeholders.
  • I have tested the OAS changes using a tool like Swagger editor

@valerierose valerierose marked this pull request as draft December 20, 2024 23:20
@valerierose valerierose marked this pull request as ready for review December 21, 2024 00:24
@manan19 manan19 merged commit 2a57e8b into main Dec 22, 2024
1 check passed
@manan19 manan19 deleted the val/neyn-4012-update-oas-with-new-fids-param-for-feedchannel branch December 22, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manan19 manan19 manan19 approved these changes

@Shreyaschorge Shreyaschorge Awaiting requested review from Shreyaschorge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valerierose @manan19