Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GET frame/notification_tokens [NEYN-3953] #269

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Conversation

nounder
Copy link
Contributor

@nounder nounder commented Dec 20, 2024

@nounder nounder self-assigned this Dec 20, 2024
Copy link
Collaborator

@Shreyaschorge Shreyaschorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes.
Please update the OAS version

src/v2/spec.yaml Show resolved Hide resolved
src/v2/spec.yaml Outdated Show resolved Hide resolved
src/v2/spec.yaml Outdated Show resolved Hide resolved
@nounder
Copy link
Contributor Author

nounder commented Dec 20, 2024

Thanks @Shreyaschorge. All fixed in b933b57

src/v2/spec.yaml Show resolved Hide resolved
src/v2/spec.yaml Outdated Show resolved Hide resolved
- notification_token
token:
type: string
status:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

status should be enum of values

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on code search, i added enabled and disabled statuses

@nounder nounder requested a review from manan19 December 20, 2024 20:44
@manan19 manan19 merged commit 7c80bcd into main Dec 20, 2024
1 check passed
@manan19 manan19 deleted the rafi/notif-tokens branch December 20, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants