Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OAS for /signer/list and /login/nonce #268

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Conversation

Shreyaschorge
Copy link
Collaborator

@Shreyaschorge Shreyaschorge commented Dec 20, 2024

Description of the Change

OAS Change Summary

Add 2 new endpoints

New Endpoints

  • GET /v2/farcaster/login/nonce - Fetch nonce to sign message
  • GET /v2/farcaster/signer/list - Fetch signer list for a custody address

New/Updated Schemas

  • NewSchema - Schema for a new resource.
  • UpdatedSchema - Modified to include additional fields.

Checklist

  • I have validated that all new/updated endpoints conform to OAS standards.
  • I have updated or added necessary schema definitions.
  • I have ensured that the new schema I have added doesn't exist.
  • I have added description wherever necessary.
  • I have ensured that endpoint's responses are correct.
  • I have considered backward compatibility with previous versions of the API.
  • I have communicated any breaking changes to the appropriate stakeholders.
  • I have tested the OAS changes using a tool like Swagger editor

Additional Comments

@manan19 manan19 merged commit 507fef4 into main Dec 20, 2024
1 check passed
@manan19 manan19 deleted the shreyas/neyn-4001-add-oas branch December 20, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants