Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversation summary #267

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Add conversation summary #267

merged 2 commits into from
Dec 18, 2024

Conversation

nounder
Copy link
Contributor

@nounder nounder commented Dec 17, 2024

Description of the Change

https://github.com/neynarxyz/monorepo/pull/1116

OAS Change Summary

New Endpoints

  • GET /farcaster/cast/conversation/summary

Updated Endpoints

Deprecated Endpoints

New/Updated Schemas

Checklist

  • I have validated that all new/updated endpoints conform to OAS standards.
  • I have updated or added necessary schema definitions.
  • I have ensured that the new schema I have added doesn't exist.
  • I have added description wherever necessary.
  • I have ensured that endpoint's responses are correct.
  • I have considered backward compatibility with previous versions of the API.
  • I have communicated any breaking changes to the appropriate stakeholders.
  • I have tested the OAS changes using a tool like Swagger editor

Additional Comments

@nounder nounder self-assigned this Dec 17, 2024
@nounder nounder requested a review from manan19 December 17, 2024 14:56
@nounder
Copy link
Contributor Author

nounder commented Dec 17, 2024

@manan19 on the checklist there is "I have tested the OAS changes using a tool like Swagger editor"

When I copy-paste spec to the editor it fails (even on main branch) with the following. Is it a leftover from past? Do we need this checklist item?

CleanShot 2024-12-17 at 22 01 05@2x

@Shreyaschorge
Copy link
Collaborator

@manan19 on the checklist there is "I have tested the OAS changes using a tool like Swagger editor"

When I copy-paste spec to the editor it fails (even on main branch) with the following. Is it a leftover from past? Do we need this checklist item?

CleanShot 2024-12-17 at 22 01 05@2x

@nounder

This version of the swagger editor supports v3.0.0
we moved from OAS v3.0.0 to v3.1.0
the new one is this.
Thanks for pointing this out, will update it

Copy link
Collaborator

@Shreyaschorge Shreyaschorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nounder
Small change.
Rest looks good

src/v2/spec.yaml Show resolved Hide resolved
@Shreyaschorge
Copy link
Collaborator

@nounder
Also please update the version of OAS info.version this will make sure that a PR is raised from OAS to nodejs-sdk repo

@nounder
Copy link
Contributor Author

nounder commented Dec 18, 2024

@Shreyaschorge thanks for nothing a mistake. It was fixed and a version bumped

Copy link
Collaborator

@Shreyaschorge Shreyaschorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shreyaschorge Shreyaschorge merged commit 2108750 into main Dec 18, 2024
1 check passed
@Shreyaschorge Shreyaschorge deleted the rafi/conv-summary branch December 18, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants