-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adjust url for task links #6550
Conversation
Signed-off-by: Raimund Schlüßler <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6550 +/- ##
=========================================
Coverage 23.33% 23.33%
Complexity 453 453
=========================================
Files 248 248
Lines 11777 11777
Branches 2245 2245
=========================================
Hits 2748 2748
Misses 8705 8705
Partials 324 324
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Please change tests as well. |
Signed-off-by: Raimund Schlüßler <[email protected]>
Thanks for fixing this! When is this going to be released? I wonder why this change was not included in one of the latest releases of calender where younger changes where included? |
/backport to stable5.0 |
The backport to # Switch to the target branch and update it
git checkout stable5.0
git pull origin stable5.0
# Create the new backport branch
git checkout -b backport/6550/stable5.0
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 89294cb3 fc914bfb
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6550/stable5.0 Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Thanks! The backport is still open, see #6586 |
The URL to tasks in the Task app changed with nextcloud/tasks#2480 which was released with Tasks 0.16.0. This fix should be backported to the last version supporting Nextcloud 28 which is the oldest server version supported by Tasks 0.16.0.
Closes #6533.