Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust url for task links #6550

Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix: adjust url for task links #6550

merged 2 commits into from
Dec 4, 2024

Conversation

raimund-schluessler
Copy link
Member

The URL to tasks in the Task app changed with nextcloud/tasks#2480 which was released with Tasks 0.16.0. This fix should be backported to the last version supporting Nextcloud 28 which is the oldest server version supported by Tasks 0.16.0.

Closes #6533.

Signed-off-by: Raimund Schlüßler <[email protected]>
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.33%. Comparing base (f77d285) to head (fc914bf).
Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6550   +/-   ##
=========================================
  Coverage     23.33%   23.33%           
  Complexity      453      453           
=========================================
  Files           248      248           
  Lines         11777    11777           
  Branches       2245     2245           
=========================================
  Hits           2748     2748           
  Misses         8705     8705           
  Partials        324      324           
Flag Coverage Δ
javascript 14.95% <100.00%> (ø)
php 59.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tcitworld
Copy link
Member

Please change tests as well.

@raimund-schluessler raimund-schluessler merged commit e86c82a into main Dec 4, 2024
37 checks passed
@raimund-schluessler raimund-schluessler deleted the fix/6533/task-url branch December 4, 2024 15:38
@manfredu
Copy link

Thanks for fixing this!

When is this going to be released?

I wonder why this change was not included in one of the latest releases of calender where younger changes where included?

@st3iny
Copy link
Member

st3iny commented Dec 20, 2024

Backports were missing.

backported to the last version supporting Nextcloud 28

That is a bit tricky. For Calendar, that would be the stable4.7 branch which also supports Nextcloud 26 and 27.

Let's backport to stable5.0 for now to avoid breakage on older instances.

image

@st3iny
Copy link
Member

st3iny commented Dec 20, 2024

/backport to stable5.0

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Dec 20, 2024
@st3iny st3iny added bug Feature: Integration An integration with another app in the ecosystem labels Dec 20, 2024
Copy link

backportbot bot commented Dec 20, 2024

The backport to stable5.0 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable5.0
git pull origin stable5.0

# Create the new backport branch
git checkout -b backport/6550/stable5.0

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 89294cb3 fc914bfb

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6550/stable5.0

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@st3iny st3iny added the 4. to release Ready to be released and/or waiting for tests to finish label Dec 20, 2024
@manfredu
Copy link

/backport to stable5.0

Thanks!

The backport is still open, see #6586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish backport-request A backport was requested for this pull request bug Feature: Integration An integration with another app in the ecosystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tasks not opened from calendar
4 participants