Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): improve attendee and resource status display #6520

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Nov 24, 2024

Resolves #4983

I refactored the logic and moved it to a computed prop to facilitate making use of the schedule status as well.

I also implemented some custom status messages if the scheduling fails for some reason (statuses 3.x and 5.x).

Screenshots

Organizer's view

Invitees Resources
image spectacle_20241124_205940

(In the example above, the user test was just added and the event was not saved yet. The same applies to the resource Croc.)

Attendee's view

image

@st3iny st3iny added 3. to review Waiting for reviews enhancement New feature request Feature: Editor Feature: Scheduling Anything around scheduling meetings, free-busy, resources, attendees and so on labels Nov 24, 2024
@st3iny st3iny self-assigned this Nov 24, 2024
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 47 lines in your changes missing coverage. Please review.

Project coverage is 23.31%. Comparing base (7ed3e6e) to head (2f8a224).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...rc/components/Editor/AvatarParticipationStatus.vue 0.00% 38 Missing ⚠️
src/components/Editor/Resources/ResourceList.vue 0.00% 3 Missing ⚠️
src/components/Editor/Invitees/InviteesList.vue 0.00% 2 Missing ⚠️
...rc/components/Editor/Invitees/InviteesListItem.vue 0.00% 2 Missing ⚠️
...c/components/Editor/Resources/ResourceListItem.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6520      +/-   ##
============================================
- Coverage     23.33%   23.31%   -0.03%     
  Complexity      453      453              
============================================
  Files           248      248              
  Lines         11777    11788      +11     
  Branches       2246     2247       +1     
============================================
  Hits           2748     2748              
- Misses         8705     8716      +11     
  Partials        324      324              
Flag Coverage Δ
javascript 14.93% <0.00%> (-0.02%) ⬇️
php 59.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@st3iny st3iny requested a review from GretaD December 17, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature request Feature: Editor Feature: Scheduling Anything around scheduling meetings, free-busy, resources, attendees and so on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't show "Invitation sent" on shared calendars
1 participant