Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appointments): properly localise the calendar events #6163

Merged

Conversation

miaulalala
Copy link
Contributor

Fixes #6156

@miaulalala miaulalala added 3. to review Waiting for reviews bug labels Jul 15, 2024
@miaulalala miaulalala added this to the v5.0.0 milestone Jul 15, 2024
@miaulalala miaulalala self-assigned this Jul 15, 2024
@miaulalala
Copy link
Contributor Author

/backport to stable4.7

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Jul 15, 2024
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Test will probably fail

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.97%. Comparing base (6d1a23d) to head (74df703).
Report is 9 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6163      +/-   ##
============================================
- Coverage     23.97%   23.97%   -0.01%     
  Complexity      457      457              
============================================
  Files           247      247              
  Lines         11605    11606       +1     
  Branches       2177     2188      +11     
============================================
  Hits           2782     2782              
- Misses         8508     8509       +1     
  Partials        315      315              
Flag Coverage Δ
javascript 15.46% <ø> (ø)
php 59.53% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny
Copy link
Member

st3iny commented Jul 15, 2024

Test will probably fail

Nope, I guess we could need some tests for this case 😁


Php linter is not happy:

   1) lib/Service/Appointments/BookingCalendarWriter.php
      ---------- begin diff ----------
--- /home/runner/actions-runner/_work/calendar/calendar/lib/Service/Appointments/BookingCalendarWriter.php
+++ /home/runner/actions-runner/_work/calendar/calendar/lib/Service/Appointments/BookingCalendarWriter.php
@@ -14,7 +14,6 @@
 use OCP\Calendar\ICreateFromString;
 use OCP\Calendar\IManager;
 use OCP\IConfig;
-use OCP\IL10N;
 use OCP\IUserManager;
 use OCP\L10N\IFactory;
 use OCP\Security\ISecureRandom;

      ----------- end diff -----------

@miaulalala miaulalala force-pushed the fix/6156/fix-appointment-pre-and-post-localisations branch from 8971b34 to 74df703 Compare July 15, 2024 21:14
@miaulalala miaulalala enabled auto-merge July 15, 2024 21:14
@miaulalala miaulalala merged commit a1dff32 into main Jul 15, 2024
42 of 43 checks passed
@miaulalala miaulalala deleted the fix/6156/fix-appointment-pre-and-post-localisations branch July 15, 2024 21:18
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
Development

Successfully merging this pull request may close these issues.

appointments: internationalization i10n for confirmation email & calendar entries not correct
3 participants