-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update php and nextcloud versions #6147
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6147 +/- ##
=========================================
Coverage 23.97% 23.97%
Complexity 457 457
=========================================
Files 247 247
Lines 11606 11606
Branches 2189 2188 -1
=========================================
Hits 2782 2782
- Misses 8508 8509 +1
+ Partials 316 315 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make it a feat!
commit please because this is a breaking change that warrants a major bump
99f2798
to
0d95bdc
Compare
Composer lock file needs to be updated because of the PHP update ( Also, I guess you can't move updating the test matrices to another PR because tests will fail here. You should drop all |
01a8512
to
18ad7d6
Compare
Signed-off-by: Anna Larch <[email protected]>
191b5f5
to
1917636
Compare
Needs a follow up for the test matrix as we shouldn't test against stable27 / 28 / 29 any more.