Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update calendar sharing icon #6143

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

germelmann
Copy link
Member

fixes: #6140

@germelmann germelmann requested a review from GretaD July 11, 2024 10:48
@germelmann germelmann self-assigned this Jul 11, 2024
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 29.84%. Comparing base (3203378) to head (55cb697).
Report is 1 commits behind head on main.

Files Patch % Lines
...ppNavigation/EditCalendarModal/PublishCalendar.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6143      +/-   ##
============================================
+ Coverage     24.08%   29.84%   +5.75%     
- Complexity      457      914     +457     
============================================
  Files           247      289      +42     
  Lines         11532    13768    +2236     
  Branches       2166     2165       -1     
============================================
+ Hits           2778     4109    +1331     
- Misses         8439     9345     +906     
+ Partials        315      314       -1     
Flag Coverage Δ
javascript 15.56% <0.00%> (ø)
php 59.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@germelmann germelmann force-pushed the fix/6140/update-calendar-sharing-icon branch from 109a845 to 55cb697 Compare July 11, 2024 11:52
@miaulalala miaulalala merged commit b780c9d into main Jul 11, 2024
41 of 42 checks passed
@miaulalala miaulalala deleted the fix/6140/update-calendar-sharing-icon branch July 11, 2024 16:39
@miaulalala miaulalala added this to the v5.0.0 milestone Jul 23, 2024
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update sharing icon to match Files in Nextcloud 30
2 participants