fix: use first day of week setting from server #6134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialize moment, FullCalender and our date picker using the global first day of week setting from server. It is currently derived from a user's locale and provided by `@nextcloud/l10n`. Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
added
3. to review
|
/backport to stable4.7 |
backportbot
bot
added
the
backport-request
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6134 +/- ##
=========================================
Coverage 24.08% 24.08%
Complexity 457 457
=========================================
Files 247 247
Lines 11534 11532 -2
Branches 2165 2166 +1
=========================================
Hits 2778 2778
+ Misses 8441 8439 -2
Partials 315 315
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ChristophWurst
approved these changes
Jul 10, 2024
backportbot
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #384 (does not solve the issue but helps with it)
Initialize moment, FullCalender and our date picker using the global first day of week setting from server. It is currently derived from a user's locale and provided by
@nextcloud/l10n.This should make Calendar more consistent with the locale preview in the personal user settings (below the locale select).
https://github.com/nextcloud-libraries/nextcloud-l10n/blob/b65c8b6d9ff9c3178aeae466ccdc7a8e1406cf32/lib/date.ts#L5-L17