Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attachment folder picker #6082

Merged
merged 1 commit into from
Jul 1, 2024
Merged

fix: attachment folder picker #6082

merged 1 commit into from
Jul 1, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Jun 25, 2024

There were some breaking changes in the dialogs library we missed.

Before: Default attachment folder picker doesn't open.
After: It opens as usual.

Does not need to be backported as the dependency bump was not backported.

@st3iny st3iny added 3. to review Waiting for reviews bug labels Jun 25, 2024
@st3iny st3iny added this to the v4.8.0 milestone Jun 25, 2024
@st3iny st3iny self-assigned this Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 24.02%. Comparing base (9cb56bd) to head (93374fa).
Report is 5 commits behind head on main.

Files Patch % Lines
...pNavigation/Settings/SettingsAttachmentsFolder.vue 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6082      +/-   ##
============================================
- Coverage     29.71%   24.02%   -5.69%     
+ Complexity      914      457     -457     
============================================
  Files           287      246      -41     
  Lines         13835    11565    -2270     
  Branches       2163     2153      -10     
============================================
- Hits           4111     2779    -1332     
+ Misses         9409     8472     -937     
+ Partials        315      314       -1     
Flag Coverage Δ
javascript 15.56% <0.00%> (-0.01%) ⬇️
php 58.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny st3iny force-pushed the fix/attachment-folder-picker branch from 3ebd468 to 0b8d036 Compare June 25, 2024 18:11
@ChristophWurst
Copy link
Member

conflicts again

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 26, 2024
There were some breaking changes in the dialogs library we missed.

Signed-off-by: Richard Steinmetz <[email protected]>
@st3iny st3iny force-pushed the fix/attachment-folder-picker branch from 0b8d036 to 93374fa Compare July 1, 2024 07:29
@st3iny st3iny enabled auto-merge July 1, 2024 07:35
@st3iny st3iny merged commit d644634 into main Jul 1, 2024
40 of 42 checks passed
@st3iny st3iny deleted the fix/attachment-folder-picker branch July 1, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
Development

Successfully merging this pull request may close these issues.

3 participants