Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overlapping toggle also in Firefox #5490

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Fix overlapping toggle also in Firefox #5490

merged 1 commit into from
Sep 26, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Sep 25, 2023 •
edited
Loading

@szaimen szaimen added 3. to review Waiting for reviews bug labels Sep 25, 2023
@szaimen szaimen added this to the v4.6.0 milestone Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (933e503) 22.59% compared to head (7279bfc) 22.59%.
Report is 13 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #5490   +/-   ##
=========================================
  Coverage     22.59%   22.59%           
  Complexity      395      395           
=========================================
  Files           241      241           
  Lines         11854    11854           
  Branches       2306     2306           
=========================================
  Hits           2679     2679           
  Misses         9175     9175
Flag Coverage Δ
javascript 13.81% <0.00%> (ø)
php 64.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/mixins/EditorMixin.js 3.47% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

raimund-schluessler
raimund-schluessler approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@raimund-schluessler raimund-schluessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Day and Week view are fine now 👍

@szaimen
Copy link
Contributor Author

szaimen commented Sep 25, 2023

CI failure unrelated afaics

st3iny
st3iny approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@st3iny st3iny merged commit e580422 into main Sep 26, 2023
@st3iny st3iny deleted the enh/noid/fix-firefox-toggle branch September 26, 2023 12:05
@st3iny
Copy link
Member

st3iny commented Sep 26, 2023

/backport to stable4.5

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request A backport was requested for this pull request label Sep 26, 2023
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 26, 2023
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 26, 2023
Merged
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request A backport was requested for this pull request label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@st3iny st3iny st3iny approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@GretaD GretaD Awaiting requested review from GretaD

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
v4.6.0
Development

Successfully merging this pull request may close these issues.

Mobile menu toggle for navigation overlaps with content (especially in Mail & Contacts)
3 participants
@szaimen @st3iny @raimund-schluessler