Skip to content

Commit

Permalink
ci: allow coverage upload to fail
Browse files Browse the repository at this point in the history
Otherwise, PRs from (community) forks will never have green CI. In my
opinion we can tolerate having no coverage info from the occasional
community contributor as long as the tests are successful.

Signed-off-by: Richard Steinmetz <[email protected]>
  • Loading branch information
st3iny committed Jul 12, 2024
1 parent b780c9d commit 8674d1b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/npm-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
file: ./coverage/coverage-final.json
flags: javascript
fail_ci_if_error: true
fail_ci_if_error: false

summary:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/php-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}
file: nextcloud/apps/calendar/clover.unit.xml
flags: php
fail_ci_if_error: true
fail_ci_if_error: false
verbose: true

integration-tests:
Expand Down

0 comments on commit 8674d1b

Please sign in to comment.