Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(confirmation) Modal #408

Closed
rullzer opened this issue May 21, 2019 · 3 comments
Closed

(confirmation) Modal #408

rullzer opened this issue May 21, 2019 · 3 comments
Labels
1. to develop Accepted and waiting to be taken care of component Component discussion and/or suggestion
Milestone

Comments

@rullzer
Copy link
Contributor

rullzer commented May 21, 2019

This came up during the development of nextcloud/server#15104

It would be great if we could show a proper styled (confirmation) modal. Similar to the password confirmation input but then just some text and 'OK', 'Cancel" etc.

Since in some (destructive) cases it really is worth it to get the extra confirmation. And having it properly styled would be awesome.

@ChristophWurst @skjnldsv @juliushaertl

@juliusknorr
Copy link
Contributor

We currently have OC.dialogs.confirm() in the server js, so we should probably replace that in the same run once we have a proper component.

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of component Component discussion and/or suggestion labels May 22, 2019
@ChristophWurst
Copy link
Contributor

We currently have OC.dialogs.confirm() in the server js, so we should probably replace that in the same run once we have a proper component.

Alternative: we don't even ship this anymore with the server but let apps use the component from this lib directly -> small core js -> happy core js devs 😉

@Antreesy
Copy link
Contributor

Should be resolved with #4550

@Antreesy Antreesy added this to the 8.0.0 milestone Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of component Component discussion and/or suggestion
Projects
None yet
Development

No branches or pull requests

5 participants