-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue dialogs #15891
Comments
@skjnldsv Shouldn't this ticket be in the nextcloud-vue repo? |
No, because this is about the OC.Dialog implementation. |
We can still have them in nextcloud-vue and re-export in server if really needed. I would keep the number of OC.Dialog APIs as minimum as possible. |
Maybe we just need more description to understand what this ticket is about @skjnldsv 😉 |
@ChristophWurst well, just replace OC.Dialog? What can I tell more? 🤔 |
Shouldn't we try to deprecate OC.Dialog and let it die eventually? |
(I forgot there is |
Well, I'll argue against it by saying this would force everyone to use vue. The dialog component could contain lots of things, and therefoe require a vue component (standard) |
cc @ChristophWurst
Relevant: nextcloud-libraries/nextcloud-vue#408
Closes #6601
The text was updated successfully, but these errors were encountered: