Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue dialogs #15891

Closed
skjnldsv opened this issue Jun 6, 2019 · 9 comments
Closed

Vue dialogs #15891

skjnldsv opened this issue Jun 6, 2019 · 9 comments

Comments

@skjnldsv
Copy link
Member

skjnldsv commented Jun 6, 2019

cc @ChristophWurst

Relevant: nextcloud-libraries/nextcloud-vue#408

Closes #6601

@skjnldsv skjnldsv added enhancement 1. to develop Accepted and waiting to be taken care of technical debt labels Jun 6, 2019
@georgehrke
Copy link
Member

@skjnldsv Shouldn't this ticket be in the nextcloud-vue repo?

@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 6, 2019

No, because this is about the OC.Dialog implementation.
The nextcloud-vue repo is about the component itself ;)

@ChristophWurst
Copy link
Member

We can still have them in nextcloud-vue and re-export in server if really needed. I would keep the number of OC.Dialog APIs as minimum as possible.

@ChristophWurst
Copy link
Member

Maybe we just need more description to understand what this ticket is about @skjnldsv 😉

@skjnldsv
Copy link
Member Author

@ChristophWurst well, just replace OC.Dialog? What can I tell more? 🤔

@georgehrke
Copy link
Member

Shouldn't we try to deprecate OC.Dialog and let it die eventually?
It's enough if there is an equivalent in vue-components, i don't see a need to ship it in the server

@georgehrke
Copy link
Member

(I forgot there is OC.dialogs.filepicker. That we should definitely keep)

@skjnldsv
Copy link
Member Author

skjnldsv commented Jun 11, 2019

It's enough if there is an equivalent in vue-components, i don't see a need to ship it in the server

Well, I'll argue against it by saying this would force everyone to use vue.
If I have a tiny script with pure javascript (which is far better than having a full vue app to compile) that takes 10 lines because it require two checkboxes and a dialog, I would say we should keep a standard.

The dialog component could contain lots of things, and therefoe require a vue component (standard)
But the use cases on server are simple and should be something like: password input, confirm dialog, duplicate file dialog. (anything else?)

@skjnldsv
Copy link
Member Author

@skjnldsv skjnldsv closed this as completed Jan 2, 2024
@skjnldsv skjnldsv removed the 1. to develop Accepted and waiting to be taken care of label Jan 2, 2024
@skjnldsv skjnldsv added this to the Nextcloud 28 milestone Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants