[2-1단계 - 테마 관리 기능 추가] #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyeon9mak
requested changes
Jun 27, 2024
Comment on lines
+10
to
+19
| @RestController | ||
| @RequestMapping("/themes") | ||
| public class ThemeController { | ||
|
|
||
| private final ThemeService themeService; | ||
|
|
||
| @Autowired | ||
| public ThemeController(ThemeService themeService) { | ||
| this.themeService = themeService; | ||
| } |
There was a problem hiding this comment.
생성자 쪽에 @Autowired 를 생략할 수 있겠어요!
Comment on lines
+30
to
+38
| @Autowired | ||
| public ReservationRepository(JdbcTemplate jdbcTemplate) { | ||
| this.jdbcTemplate = jdbcTemplate; | ||
| this.jdbcInsert = new SimpleJdbcInsert(jdbcTemplate) | ||
| .withTableName("reservation") | ||
| .usingGeneratedKeyColumns("id"); | ||
| } | ||
|
|
||
| public Long save(Reservation reservation) { |
There was a problem hiding this comment.
역시나 @Autowired 어노테이션을 생략할 수 있을거 같아요 😄
Comment on lines
+39
to
+47
| Map<String, Object> params = new HashMap<>(); | ||
| params.put("name", reservation.getName()); | ||
| params.put("date", reservation.getDate()); | ||
| params.put("time_id", reservation.getTimeId()); | ||
| params.put("theme_id", reservation.getThemeId()); | ||
|
|
||
| return jdbcInsert.executeAndReturnKey(params).longValue(); | ||
| } | ||
|
|
There was a problem hiding this comment.
simpleJdbcInsert 를 사용한 덕분에 코드가 엄청 간결해졌네요!
Comment on lines
+17
to
+22
| } | ||
|
|
||
| public Long addReservation(Reservation reservation) { | ||
| return reservationRepository.save(reservation); | ||
| } | ||
|
|
There was a problem hiding this comment.
한 시간대에 중복 예약이 되지 않도록 검증해주는 로직이 추가되면 더 좋겠네요!
Hyeon9mak
reviewed
Jun 27, 2024
Comment on lines
+48
to
+50
| public List<Reservation> readAll() { | ||
| String sql = "SELECT r.id, r.name as reservation_name, t.name as theme_name, r.date, rt.start_at as start_at FROM reservation as r INNER JOIN reservation_time as rt ON r.time_id = rt.id INNER JOIN theme as t ON r.theme_id = t.id"; | ||
| return jdbcTemplate.query(sql, rowMapper); |
There was a problem hiding this comment.
Reservation 을 우선 조회한 후, ReservationTimeRepository 를 통해 ReservationTime 을 조회하는 건 어떨까요?
쿼리 횟수가 1회 증가하지만 그것이 부담스럽지 않은 상태이고,
쿼리가 짧아져서 이해하기에도, 유지보수하기에도 더 좋은 상태가 될거 같아요!
또한 질문주신 문제점도 쉽게 해결해볼 수 있을거라 생각되네요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
리뷰어님 안녕하세요! 지난 번에 말씀드린 오류는 잘 해결되었습니다.
다만 현재 어려움을 겪고 있는 부분이 하나 있습니다.
테스트 시 예약 시간 및 테마는 잘 추가되는데요, 예약 추가 시 예약 ID와 예약자명을 제외한 나머지 정보는 화면에 출력되지 않고 있습니다. ReservationRepository에 SQL 구문이나 RowMapper 설정 쪽에 문제가 있을 것으로 예측되는데 잘 모르겠어 문의드립니다. 감사합니다!