Skip to content

Commit

Permalink
[183_contamination_by_irradiated], issue #183, Implementation of init…
Browse files Browse the repository at this point in the history
…ialization_helper methods for Lead and Bismuth Henry constant in liquid lbe to help pass the tests. Addition of boundary's values of Lead and Bismuth Henry constant in liquid LBE in properties_bounds.json.
  • Loading branch information
Sami Amestas committed Aug 6, 2024
1 parent 6d5e0ab commit a8323da
Show file tree
Hide file tree
Showing 2 changed files with 50 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,25 @@ def correlation(self, T: float, p: float = atm,
"""
return np.power(10, - 10130 / T - 0.985 * np.log(T) + 12.8163)

def initialization_helper(self,
property_value: float) -> Union[None, float]:
"""
Returns the temperature guess value according to the value
of the Lead Henry constant passed as argument.
It is used by the root finder algorithm.
Parameters
----------
property_value : float
Lead Henry constant in :math:`[Pa]`
Returns
-------
float
Temperature guess value in :math:`[K]`
"""
return 1500

@property
def name(self) -> str:
"""
Expand Down Expand Up @@ -333,6 +352,25 @@ def correlation(self, T: float, p: float = atm,
"""
return np.power(10, - 9656.4 / T + 9.9272)

def initialization_helper(self,
property_value: float) -> Union[None, float]:
"""
Returns the temperature guess value according to the value
of the Bismuth Henry constant passed as argument.
It is used by the root finder algorithm.
Parameters
----------
property_value : float
Bismuth Henry constant in :math:`[Pa]`
Returns
-------
float
Temperature guess value in :math:`[K]`
"""
return 1500

@property
def name(self) -> str:
"""
Expand Down
12 changes: 12 additions & 0 deletions tests/properties_bounds.json
Original file line number Diff line number Diff line change
Expand Up @@ -635,6 +635,12 @@
"max": 0.4858986607,
"T_at_max": 1172.9999798861
},
"bi_Kh_lbh15_bismuth_Henry_constant_in_liquid_lbe": {
"min": 0.0000027608,
"T_at_min": 623.5500154587,
"max": 0.0030945479,
"T_at_max": 776.4499805994
},
"G_lbh15_Gibbs_free_energy_variation_in_liquid_lbe": {
"min": -44.6276162032,
"T_at_min": 1926.9999545753,
Expand All @@ -647,6 +653,12 @@
"max": 0.3681810562,
"T_at_max": 1172.9999798861
},
"pb_Kh_lbh15_lead_Henry_constant_in_liquid_lbe": {
"min": 0.0000000002,
"T_at_min": 623.5500144393,
"max": 0.0000001640,
"T_at_max": 776.4499805994
},
"H_lbh15_molar_enthalpy_variation_in_liquid_lbe": {
"min": 0.0617067764,
"T_at_min": 400.0000107974,
Expand Down

0 comments on commit a8323da

Please sign in to comment.