Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(food): add unique hashed meal id #22

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

Robert27
Copy link
Member

This pull request includes several updates to dependencies and modifications to the meal data handling in the codebase. The most important changes include updating dependencies in package.json, adding new fields to the GraphQL schema, and refactoring the meal hashing functions to use a different hashing library.

Dependency Updates:

  • Updated several dependencies and devDependencies in package.json, including drizzle-orm, @commitlint/cli, and @eslint/eslintrc. Added @node-rs/xxhash and removed object-hash. [1] [2]

GraphQL Schema Changes:

  • Added mealId field to Meal and Variation types in src/schema/types.gql to uniquely identify meals independent of the day. [1] [2]

Meal Hashing Refactor:

  • Replaced getMealHash with getMealDayHash in multiple files (src/scraping/canisius.ts, src/scraping/mensa.ts, src/scraping/reimanns.ts) to use the new hashing function. [1] [2] [3]
  • Updated getMealHash and getMealDayHash functions in src/utils/food-utils.ts to use xxhash instead of object-hash. [1] [2]

@Robert27 Robert27 requested a review from Copilot November 21, 2024 20:33

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 8 changed files in this pull request and generated no suggestions.

Files not reviewed (2)
  • package.json: Language not supported
  • src/schema/types.gql: Language not supported
@Robert27 Robert27 marked this pull request as ready for review November 21, 2024 20:38
@Robert27 Robert27 self-assigned this Nov 21, 2024
@Robert27 Robert27 merged commit e21a277 into develop Nov 21, 2024
3 checks passed
@Robert27 Robert27 deleted the feat/unique-meal-id branch November 21, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants