Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup unused dependency #61

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

lukasholzer
Copy link
Contributor

@lukasholzer lukasholzer commented Oct 11, 2023

πŸŽ‰ Thanks for sending this pull request! πŸŽ‰

As we removed esbuild in #59 and replaced it with tsup – a package bundler that emit types in the correct format as well, I forgot to remove the dev dependency on esbuild.

This PR is a follow up cleaning up the unused dependency.

@lukasholzer lukasholzer requested a review from a team as a code owner October 11, 2023 14:21
@netlify
Copy link

netlify bot commented Oct 11, 2023

βœ… Deploy Preview for blobs-js ready!

Name Link
πŸ”¨ Latest commit 30bf62a
πŸ” Latest deploy log https://app.netlify.com/sites/blobs-js/deploys/6526b105829c580008c71997
😎 Deploy Preview https://deploy-preview-61--blobs-js.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Oct 11, 2023
@lukasholzer lukasholzer force-pushed the chore/cleanup-esbuild branch from 341ce4d to 66b1c26 Compare October 11, 2023 14:23
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow. If we're using esbuild to bundle the library before publishing, shouldn't it be a devDependency? Some context in the PR description would help.

@lukasholzer
Copy link
Contributor Author

I don't follow. If we're using esbuild to bundle the library before publishing, shouldn't it be a devDependency? Some context in the PR description would help.

sorry updated the description. We've removed esbuild in #59

@eduardoboucas
Copy link
Member

@lukasholzer Can you get this one across the finish line? Seems like tests are failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants