Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup elixir formatter #16

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Setup elixir formatter #16

wants to merge 8 commits into from

Conversation

olgad0110
Copy link
Contributor

Setup elixir formatter for mix.exs file and all ex/exs files in config, lib, test directories
Adjust code to fomatter (by running mix format)

@olgad0110
Copy link
Contributor Author

@nekath feel free to add any additional configuration to the formatter if you think it's necessary

@nekath
Copy link
Contributor

nekath commented Apr 15, 2018

I played a bit with formatter and importing setups from various libs like phoenix, ecto, plug.
There are a few problems at this moment

  • some of the libs formatter file is added just in master
  • currently there is a requirement to define every dependency in deps (dep from you import a rules), therefore we would need to add some libs to deps, i.e. using ecto is pulled by phoenix_ecto, so it would have to be added to deps.

Other option is to just copy-paste locals_without_parens definitions from above libs into our .formatter.exs and don't care for some time.

I'm for second option.
Nevertheless we should also add credo and run it as part of CI process :)

What do you think? :)

@olgad0110
Copy link
Contributor Author

agree, let's go with second option

Radosław Piątek added 6 commits April 16, 2018 22:43
For now let’s copy-paste rules, when most of the deps are update, we
can directly import the lists.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants