fix typos, remove redundant paragraphs and adding new figure #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanneberger
commented
May 2, 2024
| <t> | ||
| An ASPA record is a digitally signed object that binds a set of Provider AS numbers to a Customer AS (CAS) number (in terms of BGP announcements) and is signed by the CAS <xref target="I-D.ietf-sidrops-aspa-profile"/>. | ||
| The ASPA attests that the CAS indicated a Set of Provider ASes (SPAS), which applies only to the IPv4 and IPv6 address families (i.e., AFI = 1 and AFI = 2) and only to Network Layer Reachability Information used for unicast forwarding (SAFI = 1). | ||
| The definition of Provider AS is given in Section 1 of the ASPA profile object document <xref target="I-D.ietf-sidrops-aspa-profile"/>. | ||
| A function of a Provider AS is to propagate a CAS's route announcements onward, i.e., to the Provider's upstream providers, lateral peers, or customers. |
There was a problem hiding this comment.
-> explains what's the purpose of a provider in a section that is dedicated to the ASPA Record,
tanneberger
commented
May 2, 2024
| A CAS is expected to register a single ASPA listing all its Provider ASes (see <xref target="rec1"/>). | ||
| If a CAS has a single ASPA, then the SPAS for the CAS is the set of Provider ASes listed in that ASPA. | ||
| In case a CAS has multiple ASPAs, then the SPAS is the union of the Provider ASes listed in all ASPAs of the CAS. | ||
| A CAS is expected to register a single ASPA listing all its Provider ASes (see <xref target="rec1"/>), if |
There was a problem hiding this comment.
simplification of the sentence.
tanneberger
commented
May 2, 2024
| @@ -360,20 +343,37 @@ authorized(AS x, AS y) = / Else, "Provider+" if the VAP-SPAS entry | |||
| A valid path may have a one horizontal hop that represents peering relation. | |||
| </t> | |||
| <t> | |||
| <strong>Determination of Invalid AS_PATH:</strong> | |||
There was a problem hiding this comment.
Renamed this because all cases were explained with the help of the newly introduced indices.
tanneberger
force-pushed
the
draft-changes
branch
2 times, most recently
from
da30a23 to
15fcb1f
Compare
tanneberger
changed the title
Co-authored-by: Matthias Waehlisch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
@mitradir would you mind taking a look at it?