Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17686 config option for disk divider #18011

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Haeki
Copy link

@Haeki Haeki commented Nov 14, 2024

Fixes: #17686 Ability to select disk divider

I added two new config options to specify the divider used to calculate the disk and ram sizes in different units.
The default value is 1000 but can be changed to 1024 to get GiB instead of GB.
Those config values are used in the humanize_megabytes method. I split this method into two separate methods, one for RAM and one for disk values. Additionally I added the disk config value to the disk migration so that users with GiB values get them converted to MiB.
I tested the changes in my local environment and noticed no problems.

I'm open for feedback and I also didn't include any tests yet.

Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further action is taken.

@github-actions github-actions bot added the pending closure Requires immediate attention to avoid being closed for inactivity label Dec 15, 2024
@mbchristoff
Copy link

Would love to see this merged, running behind on v4.0 because of dependencies on netbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending closure Requires immediate attention to avoid being closed for inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abillity to select disk divider
2 participants