Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the url in .status.url for both IpAddress and Prefix CRs #52

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Fix the url in .status.url for both IpAddress and Prefix CRs #52

merged 1 commit into from
Sep 6, 2024

Conversation

jstudler
Copy link
Contributor

@jstudler jstudler commented Sep 6, 2024

Fixes #44

If HTTPS_ENABLE is set to false, .status.url now shows a correct http url

alexandernorth
alexandernorth approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@alexandernorth alexandernorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jstudler jstudler merged commit 8ddafe1 into main Sep 6, 2024
6 checks passed
@henrybear327 henrybear327 deleted the fix/status-url-if-https-disabled branch September 6, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandernorth alexandernorth alexandernorth approved these changes

@henrybear327 henrybear327 henrybear327 approved these changes

@faebr faebr Awaiting requested review from faebr

@ashanvbs ashanvbs Awaiting requested review from ashanvbs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If HTTPS_ENABLE is set to false, .status.url still shows https url
3 participants
@jstudler @henrybear327 @alexandernorth