Restructure the controller tests #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrybear327
requested review from
henrybear327,
alexandernorth and
jstudler
henrybear327
changed the title
henrybear327
force-pushed
the
ci/integration_test
branch
from
a74c5a2 to
b3e0e50
Compare
henrybear327
force-pushed
the
fix/controller-tests
branch
from
aa79dd6 to
b681952
Compare
|
I rebased this PR on #29 so we can see if the integration test is properly fixed! |
|
Integration test CI is now passing! |
henrybear327
force-pushed
the
fix/controller-tests
branch
from
b681952 to
5ba0a72
Compare
henrybear327
force-pushed
the
ci/integration_test
branch
from
b3e0e50 to
9b790fc
Compare
|
Hey @bruelea sorry that I have no idea what happened that made this PR merged (I didn't push the button...), but it's actually not merged into the main branch (magic?) Can you open a new PR with your branch? Thanks .. :) |
Done. Thanks @henrybear327 for testing the PR in the pipeline! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR the controller tests were restructured to avoid race conditions