Support e2e tests against multiple NetBox versions #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrybear327
requested review from
alexandernorth,
jstudler,
faebr and
bruelea
|
There might be an impact on netbox-community/netbox-chart#397 if the SQL data-loading mechanism is leveraged, as I might be splitting up the SQL file to support different NetBox versions. |
henrybear327
force-pushed
the
e2e/add_multi_version_support
branch
4 times, most recently
from
ce87756 to
b2c0462
Compare
henrybear327
force-pushed
the
e2e/add_multi_version_support
branch
3 times, most recently
from
9358c31 to
71b1543
Compare
Fix waiting for namespace condition
henrybear327
force-pushed
the
e2e/add_multi_version_support
branch
2 times, most recently
from
4ce5415 to
b152472
Compare
Increase timeout Fix misc.
henrybear327
force-pushed
the
e2e/add_multi_version_support
branch
from
b152472 to
884c1d9
Compare
It's observed that the cluster might take 1+ min to apply and have the CR finalized...
alexandernorth
requested changes
Dec 13, 2024
|
Blocked by #175 |
|
Recreated at #176 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are introducing the e2e test and running against real NetBox instances, it makes sense to test against different versions of NetBox, so we can flag issues early on.
CI will now run all e2e tests against the supported versions.
The supported NetBox versions are (the latest patch version for the
major.minorrelease):Instead of
create-kind, we now havecreate-kind-3.7.8,create-kind-4.0.11, andcreate-kind-4.1.7. The same goes formake test-e2e.The patching mechanism is used to apply database schema fixes and demo data version changes. When we introduce support for new versions, usually only the database schema would need to be changed.