Add configuration option for using system truststore #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed truststore for ssl validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change to provide a configuration option to use the linux system truststore if required like in a business environment with own pki infrastructure.
It adds an commented option to the .env.example. This keeps compability for non linux based setups but saves everyone using this project the time to search for the correct parameter for the requests librarary or from disabling verification at all.
I also updated the Readme for the container.
Using a default config option of the requests library this should work if you include the corresponding CA_BUNDLE for your organization in the container.
All in all its an little quality of life change. If I need to add something more feel free to give me some feedback and I'll will look into improving this PR.