Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance compatibility of install.sh for systems without sudo #1176

Merged
merged 4 commits into from
Sep 28, 2023

Conversation

bcmmbaga
Copy link
Contributor

Describe your changes

This merge request aims to improve the compatibility of the install.sh script with systems that do not have the sudo command available. This enhancement is particularly valuable for users in restricted environments where sudo may not be installed or accessible.

Issue ticket number and link

  • Client install script not working on system without sudo - #1170

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

This commit modifies the install.sh script to improve compatibility with systems lacking the sudo command. A conditional check is added at the beginning of the script to see if the sudo command exists. If it does, operations in the script that previously required sudo would proceed as normal, using the sudo command. If the system does not have sudo, the shell would execute these operations without it. This change enhances the usability of this script in restricted environments where sudo is not installed or available to users.
@bcmmbaga bcmmbaga force-pushed the fix-installer-script branch from 402bda3 to 07a2387 Compare September 27, 2023 12:02
@braginini braginini merged commit c81b83b into main Sep 28, 2023
21 checks passed
@braginini braginini deleted the fix-installer-script branch September 28, 2023 21:58
pulsastrix pushed a commit to pulsastrix/netbird that referenced this pull request Dec 24, 2023
…io#1176)


This commit modifies the install.sh script to improve compatibility with systems lacking the sudo command. A conditional check is added at the beginning of the script to see if the sudo command exists. If it does, operations in the script that previously required sudo would proceed as normal, using the sudo command. If the system does not have sudo, the shell would execute these operations without it. This change enhances the usability of this script in restricted environments where sudo is not installed or available to users.
Foosec pushed a commit to Foosec/netbird that referenced this pull request May 8, 2024
…io#1176)


This commit modifies the install.sh script to improve compatibility with systems lacking the sudo command. A conditional check is added at the beginning of the script to see if the sudo command exists. If it does, operations in the script that previously required sudo would proceed as normal, using the sudo command. If the system does not have sudo, the shell would execute these operations without it. This change enhances the usability of this script in restricted environments where sudo is not installed or available to users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants