-
-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add peer groups support for network routes #1150
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surik
force-pushed
the
yury/add-peer-group-to-network-route
branch
from
September 15, 2023 16:13
e391130
to
0fcab38
Compare
surik
force-pushed
the
yury/add-peer-group-to-network-route
branch
from
September 19, 2023 09:31
0a41619
to
11d23ce
Compare
mlsmaycon
reviewed
Sep 19, 2023
surik
force-pushed
the
yury/add-peer-group-to-network-route
branch
from
September 20, 2023 13:58
11d23ce
to
c44ed51
Compare
surik
changed the title
Add peers group support for network routes
Add peer groups support for network routes
Sep 21, 2023
surik
force-pushed
the
yury/add-peer-group-to-network-route
branch
from
September 25, 2023 09:48
6304d05
to
93f75a4
Compare
surik
commented
Sep 26, 2023
mlsmaycon
reviewed
Sep 26, 2023
mlsmaycon
reviewed
Sep 26, 2023
braginini
approved these changes
Sep 28, 2023
pulsastrix
pushed a commit
to pulsastrix/netbird
that referenced
this pull request
Dec 24, 2023
This commit enhances the functionality of the network routes endpoint by introducing a new parameter called `peers_group`. This addition allows users to associate network routes with specific peer groups, simplifying the management and distribution of routes within a network.
Foosec
pushed a commit
to Foosec/netbird
that referenced
this pull request
May 8, 2024
This commit enhances the functionality of the network routes endpoint by introducing a new parameter called `peers_group`. This addition allows users to associate network routes with specific peer groups, simplifying the management and distribution of routes within a network.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This pull request enhances the functionality of the network routes endpoint by introducing a new parameter called
peers_group
. This addition allows users to associate network routes with specific peer groups, simplifying the management and distribution of routes within a network.Key Changes:
New Parameter: The
peer_groups
parameter is now available when creating or updating network routes. Users can specify either a singlepeer
or apeer_groups
, streamlining the route configuration process.Enhanced Response: When retrieving information about a network route, the response will now include both
peer
andpeers_groups
fields, with one of them containing an empty string, depending on the chosen configuration. This provides clarity and consistency in route data representation.Network Route Object: The
peer_groups
attribute is seamlessly integrated into the network route object, ensuring it is stored efficiently for future use during network map distribution.Optimized Network Map Distribution: During the network map distribution phase, the
peer_groups
is expanded into a list of peers within the designated group. This optimization results in the efficient transmission of routes to clients, with a focus on filtering out non-Linux peers, streamlining the distribution process.Issue ticket number and link
Checklist