Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add peer groups support for network routes #1150

Merged
merged 18 commits into from
Sep 28, 2023

Conversation

surik
Copy link
Contributor

@surik surik commented Sep 15, 2023

Describe your changes

This pull request enhances the functionality of the network routes endpoint by introducing a new parameter called peers_group. This addition allows users to associate network routes with specific peer groups, simplifying the management and distribution of routes within a network.

Key Changes:

  • New Parameter: The peer_groups parameter is now available when creating or updating network routes. Users can specify either a single peer or a peer_groups, streamlining the route configuration process.

  • Enhanced Response: When retrieving information about a network route, the response will now include both peer and peers_groups fields, with one of them containing an empty string, depending on the chosen configuration. This provides clarity and consistency in route data representation.

  • Network Route Object: The peer_groups attribute is seamlessly integrated into the network route object, ensuring it is stored efficiently for future use during network map distribution.

  • Optimized Network Map Distribution: During the network map distribution phase, the peer_groups is expanded into a list of peers within the designated group. This optimization results in the efficient transmission of routes to clients, with a focus on filtering out non-Linux peers, streamlining the distribution process.

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@surik surik force-pushed the yury/add-peer-group-to-network-route branch from e391130 to 0fcab38 Compare September 15, 2023 16:13
@surik surik marked this pull request as ready for review September 18, 2023 14:12
@surik surik force-pushed the yury/add-peer-group-to-network-route branch from 0a41619 to 11d23ce Compare September 19, 2023 09:31
@surik surik force-pushed the yury/add-peer-group-to-network-route branch from 11d23ce to c44ed51 Compare September 20, 2023 13:58
@bcmmbaga bcmmbaga self-requested a review September 21, 2023 08:24
@surik surik changed the title Add peers group support for network routes Add peer groups support for network routes Sep 21, 2023
@surik surik force-pushed the yury/add-peer-group-to-network-route branch from 6304d05 to 93f75a4 Compare September 25, 2023 09:48
management/server/account.go Outdated Show resolved Hide resolved
management/server/account.go Outdated Show resolved Hide resolved
management/server/route.go Outdated Show resolved Hide resolved
@braginini braginini self-requested a review September 28, 2023 12:14
@surik surik merged commit 8118d60 into main Sep 28, 2023
8 checks passed
@surik surik deleted the yury/add-peer-group-to-network-route branch September 28, 2023 12:32
pulsastrix pushed a commit to pulsastrix/netbird that referenced this pull request Dec 24, 2023
This commit enhances the functionality of the network routes endpoint by introducing a new parameter called `peers_group`. This addition allows users to associate network routes with specific peer groups, simplifying the management and distribution of routes within a network.
Foosec pushed a commit to Foosec/netbird that referenced this pull request May 8, 2024
This commit enhances the functionality of the network routes endpoint by introducing a new parameter called `peers_group`. This addition allows users to associate network routes with specific peer groups, simplifying the management and distribution of routes within a network.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants