Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added promise type to async forRootAsync #19

Merged
merged 1 commit into from
Jul 4, 2019
Merged

Added promise type to async forRootAsync #19

merged 1 commit into from
Jul 4, 2019

Conversation

bashleigh
Copy link
Contributor

#17 Added promise type to useFactory method

@bashleigh bashleigh added the bug Something isn't working label Jul 4, 2019
@bashleigh bashleigh requested a review from shekohex July 4, 2019 10:54
@bashleigh bashleigh self-assigned this Jul 4, 2019
@shekohex shekohex merged commit 3bc528c into master Jul 4, 2019
@Hani-Ghazi
Copy link

hey @bashleigh, I just need part of code to make mine works, so when this pull request will be approved.
thanks in advance.

@ematipico
Copy link

Hi @bashleigh , is there any chance to publish this fix on npm please?

@bashleigh bashleigh deleted the fix/for-async-promise branch November 13, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekohex shekohex Awaiting requested review from shekohex

Assignees

@bashleigh bashleigh

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bashleigh @Hani-Ghazi @ematipico @shekohex