Split layer in python #497
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: voropz <[email protected]>
Signed-off-by: voropz <[email protected]>
Signed-off-by: voropz <[email protected]>
FedyuninV
reviewed
Dec 22, 2021
| @staticmethod | ||
| def __sizes_to_array(sizes) -> numpy.ndarray: | ||
| sizes = numpy.array(sizes, dtype=numpy.int32) | ||
| if sizes.ndim != 1 or sizes.size > 3: |
There was a problem hiding this comment.
Why do you have the upper limit of 3 here? It should be up to 31...
There was a problem hiding this comment.
I see, it was in the original layer. But that's a mistake! It should be 31. (MathEngine can handle split/merge with up to 32 parts).
FedyuninV
suggested changes
Dec 30, 2021
| @@ -62,7 +62,7 @@ def check_input_layers(input_layers, layer_count): | |||
| layers.append(i._internal) | |||
| outputs.append(0) | |||
| elif isinstance(i, (list, tuple)) and len(i) == 2 and isinstance(i[0], Layer) and isinstance(i[1], int): | |||
| if int(i[1]) < 0 or int(i[1]) >= i[0].output_count(): | |||
| if int(i[1]) < 0: | |||
There was a problem hiding this comment.
Why do you need this? Looks like a bug...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: voropz [email protected]