Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.4] Reintroduce nested models in composite models #1802

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

XFactHD
Copy link
Member

@XFactHD XFactHD commented Dec 26, 2024

This PR adds back the ability to nest child models in composite models loaded by the neoforge:composite model loader instead of being forced to reference external model files for all children. This is particularly useful when each child only consists of a parent and very little additional metadata and splitting them up would require an exorbitant amount of additional files. The ability to specify references is kept as there are a lot of cases where using a separate file is preferable.

@XFactHD XFactHD added rendering Related to rendering regression Worked previously but doesn't anymore 1.21.4 Targeted at Minecraft 1.21.4 labels Dec 26, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Dec 26, 2024

  • Publish PR to GitHub Packages

Last commit published: 710c4f8f7994be9b6c5eb7243e5fd6043c598eb0.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1802' // https://github.com/neoforged/NeoForge/pull/1802
        url 'https://prmaven.neoforged.net/NeoForge/pr1802'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1802.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1802
cd NeoForge-pr1802
curl -L https://prmaven.neoforged.net/NeoForge/pr1802/net/neoforged/neoforge/21.4.45-beta-pr-1802-inline_composite_children/mdk-pr1802.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@marchermans marchermans merged commit 069ab04 into neoforged:1.21.x Dec 27, 2024
7 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.4.46-beta.

@XFactHD XFactHD deleted the inline_composite_children branch December 27, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.4 Targeted at Minecraft 1.21.4 regression Worked previously but doesn't anymore rendering Related to rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants