Fix threading issues with ZIP archives #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that ZipFile#stream() locks the ZipFile while the stream is being iterated upon. Presumably since it expects that the ZipFile could be written to.
Since we use it read-only, we can avoid that, but now have to write our own Spliterator over the Iterator, which doesn't lock the ZipFile.
ZipFile#getInputStreamseems to be implemented in a thread-safe manner and reads on the underlying ZipFile are synchronized (which is not ideal, but doesn't crash either).