Add a new merge mappings command that works with partial parameter mappings. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last commit published: 14f45258995abf666aaf083a0c4ed9df0111c0bc. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #13' // https://github.com/neoforged/InstallerTools/pull/13
url 'https://prmaven.neoforged.net/InstallerTools/pr13'
content {
includeModule('net.neoforged.installertools', 'cli-utils')
includeModule('net.neoforged.installertools', 'jarsplitter')
includeModule('net.neoforged.installertools', 'installertools')
includeModule('net.neoforged.installertools', 'zipinject')
includeModule('net.neoforged.installertools', 'binarypatcher')
}
}
} |
Matyrobbrt
requested changes
Dec 11, 2024
src/main/java/net/neoforged/installertools/AddParamsToOfficialMappings.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/installertools/AddParamsToOfficialMappings.java
Outdated
Show resolved
Hide resolved
Matyrobbrt
approved these changes
Dec 11, 2024
|
🚀 This PR has been released as InstallerTools version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With optimized NeoForm mappings, the current merge mappings command will sadly drop official mappings that do not have corresponding entries in the NeoForm file, since it actually chains mappings rather than really merging them.
neoforged/NeoForm#13