Display markers for signs #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neocturne
force-pushed
the
sign-marker
branch
from
cb94487 to
863d5c2
Compare
Closed
neocturne
force-pushed
the
sign-marker
branch
from
863d5c2 to
8a0c0b3
Compare
neocturne
force-pushed
the
sign-marker
branch
7 times, most recently
from
6a0f514 to
b3dd9f5
Compare
neocturne
force-pushed
the
sign-marker
branch
3 times, most recently
from
af1b9cb to
bd7ca88
Compare
neocturne
force-pushed
the
sign-marker
branch
5 times, most recently
from
00cd59f to
a22e4ea
Compare
The meta version should only change when the outputs must be regenerated even if the inputs stay the same. This should never be the case for mipmap tiles, so we separate the meta version from map/lightmap tiles.
The version-specific part is extracted as an enum ChunkInner.
Allow reusing the read/write logic without requiring control over the file open.
Bincode can't deal with a number of serde's features that would be desirable if we're using the same Serialize impls for generating JSON data for the viewer.
Make mipmap-style recursive processing of tiles reusable.
Preparation for actually adding !Copy fields to BlockType. Only the Copy parts are added to the processed data, avoiding .clone() for the most part.
Allow to distinguish wall signs from freestanding or -hanging signs.
For consistency with other sign types. Signs will be shown on a separate layer.
Still needs better styling. It might also be nice to include the currently opened marker in the URL.
Allow zooming in far enough so neighboring signs don't overlap.
Allow sharing URLs that reference a marker.
Only consider sign support enabled when at least one pattern is configured.
neocturne
force-pushed
the
sign-marker
branch
from
a22e4ea to
0352168
Compare
…ull path to assets Make the script easier to use, and more consistent with sign_textures.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still work-in-progress. To implement:Currently all signs are displayedLeaflet's default marker and popup styles are usedLots of formatting information is already processed by the generator, but the viewer does not use it yet. Whitespace is currently handled incorrectly.Multiple signs with the same X/Z coordinate may exist at different Y coordinates. They must be grouped to a single marker.Closes #35