Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix data swap for water quality results #213

Merged
merged 1 commit into from
Jan 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ History
2.2.3 (unreleased)
------------------

- Nothing changed yet.
- Fix 1D/2D data swap for water quality results


2.2.3b (2024-01-02)
Expand Down
4 changes: 2 additions & 2 deletions threedigrid/admin/nodes/timeseries_mixin.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ def __init__(self, **kwargs):
super().__init__(**kwargs)


def get_substance_result_mixin(substance_name):
def get_substance_result_mixin(substance_name: str):
class NodeSubstanceResultMixin(NodeSubstanceResultMixinBase):
class Meta:
# attributes for the given fields
Expand All @@ -124,7 +124,7 @@ class Meta:
# N.B. # fields starting with '_' are private and will not be added to
# fields property
composite_fields = {
"concentration": [f"{substance_name}_1D", f"{substance_name}_2D"],
"concentration": [f"{substance_name}_2D", f"{substance_name}_1D"],
"_mesh_id": ["Mesh2DNode_id", "Mesh1DNode_id"],
}
subset_fields = {}
Expand Down
Loading