Geopackage exporter: Remove width constraint of 32 on string fields #203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change: some schematisations have e.g. pumps with display names > 32 characters. Somehow they are written correctly to the geopackage, even though the field has a constraint of 32 characters max. But when we try to copy the layer later on, it leads to errors.
@jpprins1 I could not think of a reason to put a constraint on the width of string fields in the gridadmin geopackage export. So I removed it altogether. But you may have had reasons to set this 32 max width which I am not aware of.
I did test to convert a h5 file to geopackage with this new code, and it works + solves the problem outlined above