Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geopackage exporter: Remove width constraint of 32 on string fields #203

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

leendertvanwolfswinkel
Copy link
Contributor

Reason for this change: some schematisations have e.g. pumps with display names > 32 characters. Somehow they are written correctly to the geopackage, even though the field has a constraint of 32 characters max. But when we try to copy the layer later on, it leads to errors.

@jpprins1 I could not think of a reason to put a constraint on the width of string fields in the gridadmin geopackage export. So I removed it altogether. But you may have had reasons to set this 32 max width which I am not aware of.

I did test to convert a h5 file to geopackage with this new code, and it works + solves the problem outlined above

@jpprins1
Copy link
Contributor

Lijkt me prima, denk dat ik het ergens weg gecopy-paste heb.

1 similar comment
@jpprins1
Copy link
Contributor

Lijkt me prima, denk dat ik het ergens weg gecopy-paste heb.

@jpprins1 jpprins1 merged commit 74fce5c into master Nov 7, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants