Another check for invalid row parameter.

[vranki]

Don't crash if invalid row is given. Not tested properly, but looks trivial.

[pvuorela]

Quite a lot of commits for few changed lines. Suggest rebasing&squashing. On cosmetics side, doesn't follow if () convention.

[thp]

@vranki do you think you can rework it with the feedback from Pekka?

[vranki]

Yep, I'll do it. Hopefully next week.

[vranki]

I looked at this and rebase & squash would be a pretty complex job as this is done in master branch and includes some merge conflict fixes. I suggest you just accept the pull request and I'll try to remember squashing next time. The end result should work anyway.

[chriadam]

Alternative is to just do:

git diff nemomobile/master > ../diff1.diff
git reset --hard nemomobile/master
git apply ../diff1.diff
git commit -a -m "Check rows to avoid crash if invalid row is given."
git push --force vranki master:master

That will ensure just a single commit, on top of the latest history.

[thp]

Or git rebase -i nemomobile/master and reorder/squash/fixup commits.

[thp]

@vranki I've rebased your commits here: https://github.com/nemomobile/nemo-qml-plugin-contacts/tree/invalid-row-parameter-check

Please have a look if these are the changes you want and if so, we can get this merged.

[vranki]

LGTM

[thp]

Continued here: #121